Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logArtifactLink property in RunGetLogResult. #9558

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Add logArtifactLink property in RunGetLogResult. #9558

merged 1 commit into from
Jun 12, 2020

Conversation

huanwu
Copy link
Contributor

@huanwu huanwu commented May 22, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@huanwu huanwu requested a review from northtyphoon May 22, 2020 17:44
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 22, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 22, 2020 •
edited
Loading

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 22, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 22, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 66919b1 with merge commit 43a1c59. SDK Automation 13.0.17.20200605.3
  • ️✔️@azure/arm-containerregistry [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
[npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
[npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerRegistryManagementClient.js → ./dist/arm-containerregistry.js...
[npmPack] created ./dist/arm-containerregistry.js in 708ms
[npmPack] npm notice 
[npmPack] npm notice package: @azure/[email protected]
[npmPack] npm notice === Tarball Contents === 
[npmPack] npm notice 12.3kB  esm/operations/agentPools.js                         
[npmPack] npm notice 1.9kB   esm/models/agentPoolsMappers.js                      
[npmPack] npm notice 408.6kB dist/arm-containerregistry.js                        
[npmPack] npm notice 143.5kB dist/arm-containerregistry.min.js                    
[npmPack] npm notice 2.5kB   esm/containerRegistryManagementClient.js             
[npmPack] npm notice 2.6kB   esm/containerRegistryManagementClientContext.js      
[npmPack] npm notice 9.0kB   esm/operations/exportPipelines.js                    
[npmPack] npm notice 1.8kB   esm/models/exportPipelinesMappers.js                 
[npmPack] npm notice 9.0kB   esm/operations/importPipelines.js                    
[npmPack] npm notice 1.8kB   esm/models/importPipelinesMappers.js                 
[npmPack] npm notice 345B    esm/models/index.js                                  
[npmPack] npm notice 781B    esm/operations/index.js                              
[npmPack] npm notice 145.2kB esm/models/mappers.js                                
[npmPack] npm notice 2.3kB   esm/operations/operations.js                         
[npmPack] npm notice 572B    esm/models/operationsMappers.js                      
[npmPack] npm notice 6.4kB   esm/models/parameters.js                             
[npmPack] npm notice 8.8kB   esm/operations/pipelineRuns.js                       
[npmPack] npm notice 1.8kB   esm/models/pipelineRunsMappers.js                    
[npmPack] npm notice 9.7kB   esm/operations/privateEndpointConnections.js         
[npmPack] npm notice 1.9kB   esm/models/privateEndpointConnectionsMappers.js      
[npmPack] npm notice 26.3kB  esm/operations/registries.js                         
[npmPack] npm notice 2.3kB   esm/models/registriesMappers.js                      
[npmPack] npm notice 11.4kB  esm/operations/replications.js                       
[npmPack] npm notice 1.9kB   esm/models/replicationsMappers.js                    
[npmPack] npm notice 1.0kB   rollup.config.js                                     
[npmPack] npm notice 9.1kB   esm/operations/runs.js                               
[npmPack] npm notice 1.9kB   esm/models/runsMappers.js                            
[npmPack] npm notice 11.2kB  esm/operations/scopeMaps.js                          
[npmPack] npm notice 1.8kB   esm/models/scopeMapsMappers.js                       
[npmPack] npm notice 12.0kB  esm/operations/taskRuns.js                           
[npmPack] npm notice 1.9kB   esm/models/taskRunsMappers.js                        
[npmPack] npm notice 12.0kB  esm/operations/tasks.js                              
[npmPack] npm notice 2.2kB   esm/models/tasksMappers.js                           
[npmPack] npm notice 10.9kB  esm/operations/tokens.js                             
[npmPack] npm notice 1.8kB   esm/models/tokensMappers.js                          
[npmPack] npm notice 15.1kB  esm/operations/webhooks.js                           
[npmPack] npm notice 2.0kB   esm/models/webhooksMappers.js                        
[npmPack] npm notice 1.8kB   package.json                                         
[npmPack] npm notice 457B    tsconfig.json                                        
[npmPack] npm notice 3.3kB   esm/operations/agentPools.d.ts.map                   
[npmPack] npm notice 5.9kB   esm/operations/agentPools.js.map                     
[npmPack] npm notice 1.1kB   esm/models/agentPoolsMappers.d.ts.map                
[npmPack] npm notice 1.1kB   esm/models/agentPoolsMappers.js.map                  
[npmPack] npm notice 722.3kB dist/arm-containerregistry.js.map                    
[npmPack] npm notice 104.1kB dist/arm-containerregistry.min.js.map                
[npmPack] npm notice 1.1kB   esm/containerRegistryManagementClient.d.ts.map       
[npmPack] npm notice 1.6kB   esm/containerRegistryManagementClient.js.map         
[npmPack] npm notice 501B    esm/containerRegistryManagementClientContext.d.ts.map
[npmPack] npm notice 1.4kB   esm/containerRegistryManagementClientContext.js.map  
[npmPack] npm notice 2.4kB   esm/operations/exportPipelines.d.ts.map              
[npmPack] npm notice 4.2kB   esm/operations/exportPipelines.js.map                
[npmPack] npm notice 1.1kB   esm/models/exportPipelinesMappers.d.ts.map           
[npmPack] npm notice 1.1kB   esm/models/exportPipelinesMappers.js.map             
[npmPack] npm notice 2.4kB   esm/operations/importPipelines.d.ts.map              
[npmPack] npm notice 4.2kB   esm/operations/importPipelines.js.map                
[npmPack] npm notice 1.1kB   esm/models/importPipelinesMappers.d.ts.map           
[npmPack] npm notice 1.1kB   esm/models/importPipelinesMappers.js.map             
[npmPack] npm notice 53.2kB  esm/models/index.d.ts.map                            
[npmPack] npm notice 420B    esm/operations/index.d.ts.map                        
[npmPack] npm notice 126B    esm/models/index.js.map                              
[npmPack] npm notice 435B    esm/operations/index.js.map                          
[npmPack] npm notice 7.3kB   esm/models/mappers.d.ts.map                          
[npmPack] npm notice 81.4kB  esm/models/mappers.js.map                            
[npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                   
[npmPack] npm notice 1.4kB   esm/operations/operations.js.map                     
[npmPack] npm notice 254B    esm/models/operationsMappers.d.ts.map                
[npmPack] npm notice 267B    esm/models/operationsMappers.js.map                  
[npmPack] npm notice 1.2kB   esm/models/parameters.d.ts.map                       
[npmPack] npm notice 4.8kB   esm/models/parameters.js.map                         
[npmPack] npm notice 2.4kB   esm/operations/pipelineRuns.d.ts.map                 
[npmPack] npm notice 4.2kB   esm/operations/pipelineRuns.js.map                   
[npmPack] npm notice 1.1kB   esm/models/pipelineRunsMappers.d.ts.map              
[npmPack] npm notice 1.1kB   esm/models/pipelineRunsMappers.js.map                
[npmPack] npm notice 2.5kB   esm/operations/privateEndpointConnections.d.ts.map   
[npmPack] npm notice 4.2kB   esm/operations/privateEndpointConnections.js.map     
[npmPack] npm notice 1.1kB   esm/models/privateEndpointConnectionsMappers.d.ts.map
[npmPack] npm notice 1.1kB   esm/models/privateEndpointConnectionsMappers.js.map  
[npmPack] npm notice 7.4kB   esm/operations/registries.d.ts.map                   
[npmPack] npm notice 13.1kB  esm/operations/registries.js.map                     
[npmPack] npm notice 1.3kB   esm/models/registriesMappers.d.ts.map                
[npmPack] npm notice 1.3kB   esm/models/registriesMappers.js.map                  
[npmPack] npm notice 2.8kB   esm/operations/replications.d.ts.map                 
[npmPack] npm notice 5.3kB   esm/operations/replications.js.map                   
[npmPack] npm notice 1.1kB   esm/models/replicationsMappers.d.ts.map              
[npmPack] npm notice 1.1kB   esm/models/replicationsMappers.js.map                
[npmPack] npm notice 2.9kB   esm/operations/runs.d.ts.map                         
[npmPack] npm notice 4.8kB   esm/operations/runs.js.map

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 22, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 66919b1 with merge commit 43a1c59. SDK Automation 13.0.17.20200605.3 
    [azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-02-01-preview', '2017-10-01'} in label v2018_02_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2018-09-01', '2017-10-01'} in label v2018_09_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-10-01'} in label v2019_04_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-05-01-preview', '2019-06-01-preview', '2019-05-01'} in label v2019_06_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-12-01-preview', '2019-05-01-preview', '2019-06-01-preview'} in label v2019_12_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
  • ️✔️azure-mgmt-containerregistry [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-containerregistry
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-containerregistry
[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-02-01-preview', '2017-10-01'} in label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-09-01', '2017-10-01'} in label v2018_09_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-10-01'} in label v2019_04_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-05-01-preview', '2019-06-01-preview', '2019-05-01'} in label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-12-01-preview', '2019-05-01-preview', '2019-06-01-preview'} in label v2019_12_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 0.137% size of original (original: 120438 chars, delta: 165 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model RunGetLogResult has a new parameter log_artifact_link

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 22, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented May 22, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

This was referenced May 22, 2020
Closed
Closed
Closed
Closed
Closed
northtyphoon
northtyphoon approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@northtyphoon northtyphoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huanwu
Copy link
Contributor Author

huanwu commented May 28, 2020

@fengzhou-msft Could you merge the PR? All failures are "breaking changes". We just add a new property "logArtifactLink".

@akning-ms akning-ms merged commit 43a1c59 into Azure:master Jun 12, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@huanwu @00Kai0
Add logArtifactLink property in RunGetLogResult. (Azure#9558)
145166d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@northtyphoon northtyphoon northtyphoon approved these changes

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

Assignees

@fengzhou-msft fengzhou-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huanwu @azuresdkci @northtyphoon @fengzhou-msft @akning-ms